Windows compatibility and fix for Arrays of Enums - #37
Conversation
new URL().pathname does not work on Windows
…mpatible module resolution when consuming this package
…as more than one value, we should wrap the values in brackets otherwise only the last value in the enum can be an array
'Director' | 'Station_Manager'[] is a union of Director and an array of Station_Manager
('Director' | 'Station_Manager')[] is what we are looking for
…e missing .js extension to the ts file (not obvious!) (cherry picked from commit 94f64be)
…e package versions throughout the entire tree) (cherry picked from commit c53a9be)
|
Weird - the linter failed on a generated file. I don't think that is something I did!? |
Nfinished
left a comment
Nfinished
left a comment
There was a problem hiding this comment.
Hey, thanks for your contribution, that was a good bug to catch. It looks like you're having some environmental issues, please clean up your pr (revert all but scripts/generate.ts) and we can get it merged in.
|
Happy to, but need the other bits too, unless there is another solution.
|
|
Also, I thought I read in your docs that the generated files should be submitted. Happy to ditch them if you prefer. |
|
Ah ok I got it, you're not using a bundler so the extensions are needed. Yeah that and windows compat are ok adds. Just remove the |
… the same package versions throughout the entire tree)" This reverts commit 3010f10.
|
@LakMoore create a changelog entry with |
2 participants
Hello, this is an awesome project that was just what I was looking for to replace a really old one that was not being maintained.
My project built referencing yours but would not run; node could not find the js files due to the missing .js file extension in index.ts. It took me a couple of attempts but I have fixed that.
Also, my project references the Roles of an Eve Character, but I could not use strongly typed roles. That led me to find a small error in the generator and I've fixed that.
If you'd like to accept this PR and publish a new package, I will switch my project to reference your package on npm instead of my temporary fork on github.
Hope this helps. Cheers.